<html>
<head><meta charset="utf-8"><title>Anything left to complete this PR? · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html">Anything left to complete this PR?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="217957848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217957848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217957848">(Nov 26 2020 at 01:34)</a>:</h4>
<p>Hey, noob question, here.  I have this PR: <a href="https://github.com/rust-lang/rust/pull/79000">https://github.com/rust-lang/rust/pull/79000</a>   It's been approved, it's passed everything, etc. Do I need to do something to trigger merging it?</p>



<a name="217958014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958014">(Nov 26 2020 at 01:38)</a>:</h4>
<p>It looks like it needs to be approved again. You lose the "r+'d" status when you push more commits into the PR.</p>



<a name="217958023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958023">(Nov 26 2020 at 01:39)</a>:</h4>
<p>Ah, ok.</p>



<a name="217958215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958215">(Nov 26 2020 at 01:43)</a>:</h4>
<p>I r+'d again.</p>



<a name="217958226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958226">(Nov 26 2020 at 01:43)</a>:</h4>
<blockquote>
<p>Changing find_best_match_for_name to be non-generic removed about 10KB of code from the optimized binary.</p>
</blockquote>
<p>That's awesome <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="217958297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958297">(Nov 26 2020 at 01:45)</a>:</h4>
<p>Ha, yup. I'm working on getting stats on other large dup'd functions, especially dup'd cold functions, that could easily be converted to use trait objects or other obvious things. There's really no good reason for <code>rustc</code> to be 130 MB.</p>



<a name="217958388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958388">(Nov 26 2020 at 01:47)</a>:</h4>
<p>Heh no wonder codegen takes so long! I didn't realize it was that large</p>



<a name="217958626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958626">(Nov 26 2020 at 01:53)</a>:</h4>
<p>What happens after that?  It's not that this change is super-important -- I'm just curious how the process works.</p>



<a name="217958770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958770">(Nov 26 2020 at 01:56)</a>:</h4>
<p>Once the PR is approved (r+'d not GitHub code review approved), it goes into the bors queue. Bors tests the pr on a bunch of platforms and if it passes then bors automatically merges the pr. If another pr merges before yours and causes merge conflicts, bors will also leave a comment saying it can no longer merge the pr and you'll need to rebase it.</p>



<a name="217958777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958777">(Nov 26 2020 at 01:56)</a>:</h4>
<p>You can see the current queue here: <a href="https://bors.rust-lang.org/queue/rust">https://bors.rust-lang.org/queue/rust</a></p>



<a name="217958779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958779">(Nov 26 2020 at 01:57)</a>:</h4>
<p>Right now we're in a "tree closed" state because there are CI issues so there's no point running builds until that's resolved.</p>



<a name="217958788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958788">(Nov 26 2020 at 01:57)</a>:</h4>
<p>Once that's fixed the tree will be open again and bors will start testing and merging PRs starting at the top of the queue.</p>



<a name="217958862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217958862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217958862">(Nov 26 2020 at 01:59)</a>:</h4>
<p>Woot, thanks for the explanation.</p>



<a name="217971564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/217971564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#217971564">(Nov 26 2020 at 07:20)</a>:</h4>
<blockquote>
<p>Certainly. I thought GitHub handled that as one of its forms of committing? I know ADO does, but I just assumed GH did, too.</p>
</blockquote>
<p>GitHub and the review bots _can_ squash the commits, but there's no way for them to figure out if it makes sense to leave the history intact or squash it (there's plenty of reasons to have multiple commits in a PR).</p>



<a name="218003666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Anything%20left%20to%20complete%20this%20PR%3F/near/218003666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F.html#218003666">(Nov 26 2020 at 13:51)</a>:</h4>
<p>see also <a href="https://github.com/rust-lang/triagebot/issues/821">https://github.com/rust-lang/triagebot/issues/821</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>